Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(199)

Issue 770041: code review 770041: syscall: implementing some mingw syscalls required by o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by brainman
Modified:
9 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

syscall: implementing some mingw syscalls required by os package

Patch Set 1 #

Patch Set 2 : code review 770041: syscall: implementing some mingw syscalls required by o... #

Total comments: 22

Patch Set 3 : code review 770041: syscall: implementing some mingw syscalls required by o... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -125 lines) Patch
M src/pkg/os/dir_mingw.go View 1 2 1 chunk +2 lines, -70 lines 0 comments Download
M src/pkg/os/file.go View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/os/stat_mingw.go View 1 2 1 chunk +2 lines, -25 lines 0 comments Download
M src/pkg/os/sys_mingw.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mksyscall_mingw.sh View 1 2 4 chunks +14 lines, -6 lines 0 comments Download
M src/pkg/syscall/syscall_mingw.go View 1 2 3 chunks +186 lines, -15 lines 0 comments Download
M src/pkg/syscall/syscall_mingw_386.go View 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_unix.go View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_mingw_386.go View 1 chunk +125 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_mingw_386.go View 6 chunks +91 lines, -5 lines 0 comments Download
M src/pkg/syscall/ztypes_mingw_386.go View 1 2 2 chunks +111 lines, -0 lines 0 comments Download

Messages

Total messages: 6
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change.
9 years ago (2010-03-26 03:22:03 UTC) #1
rsc1
Looks pretty good. http://codereview.appspot.com/770041/diff/2001/3001 File src/pkg/os/dir_mingw.go (right): http://codereview.appspot.com/770041/diff/2001/3001#newcode43 src/pkg/os/dir_mingw.go:43: d.nbuf, errno = syscall.Getdents(file.fd, d.buf) Seems ...
9 years ago (2010-04-01 00:45:53 UTC) #2
brainman
http://codereview.appspot.com/770041/diff/2001/3001 File src/pkg/os/dir_mingw.go (right): http://codereview.appspot.com/770041/diff/2001/3001#newcode43 src/pkg/os/dir_mingw.go:43: d.nbuf, errno = syscall.Getdents(file.fd, d.buf) > ... If this ...
9 years ago (2010-04-01 05:03:40 UTC) #3
brainman
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
9 years ago (2010-04-01 05:04:02 UTC) #4
rsc1
LGTM thanks
9 years ago (2010-04-02 07:17:10 UTC) #5
rsc
9 years ago (2010-04-02 08:11:22 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=925e1758149d ***

syscall: implementing some mingw syscalls required by os package

R=rsc
CC=golang-dev
http://codereview.appspot.com/770041

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b