Issue 76950043: state: implement SetAPIAddresses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76950043: state: implement SetAPIAddresses

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+211356, natefinch

Visibility:
Public.

Description

state: implement SetAPIAddresses We need this so that agents can watch a single document to see when API addresses change. As with the stateServers document, we create it at Open time if it doesn't already exist. Also fix some existing issues with InitializeSuite - it shouldn't really call Open before Initialize, even though that's something that Initialize does internally. Also fix one bug - Initialize was creating the stateServers document with the wrong key (blank). Luckily the impact of the bug is small because Open will have already created the document. https://code.launchpad.net/~rogpeppe/juju-core/517-state-set-api-addresses-2/+merge/211356 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: implement SetAPIAddresses #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/address.go	View	2 chunks	+36 lines, -0 lines	0 comments	Download
M	state/initialize_test.go	View	8 chunks	+18 lines, -10 lines	0 comments	Download
M	state/open.go	View	3 chunks	+23 lines, -1 line	0 comments	Download
M	state/state_test.go	View	2 chunks	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

natefinch

11 years, 3 months ago (2014-03-17 16:51:37 UTC) #2

On 2014/03/17 16:26:57, rog wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages