Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1826)

Issue 76890049: worker: factor out NewEnvironObserver

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by rog
Modified:
10 years, 1 month ago
Reviewers:
mp+212603, gz
Visibility:
Public.

Description

worker: factor out NewEnvironObserver As intimated in the TODO, we want to use this in other workers. The actual code remains the same. https://code.launchpad.net/~rogpeppe/juju-core/529-worker-NewEnvironObserver/+merge/212603 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker: factor out NewEnvironObserver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -208 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/statepolicy.go View 1 chunk +1 line, -6 lines 0 comments Download
M worker/environ.go View 3 chunks +85 lines, -0 lines 0 comments Download
M worker/environ_test.go View 4 chunks +89 lines, -8 lines 0 comments Download
D worker/instancepoller/observer.go View 1 chunk +0 lines, -94 lines 0 comments Download
D worker/instancepoller/observer_test.go View 1 chunk +0 lines, -97 lines 0 comments Download
M worker/instancepoller/worker.go View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
rog
Please take a look.
10 years, 1 month ago (2014-03-25 12:59:32 UTC) #1
gz
10 years, 1 month ago (2014-03-25 13:03:39 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b