code review 76880044: crypto/openpgp: Adding the ability to encrypt openpgp p...

crypto/openpgp: Adding the ability to encrypt openpgp private keys, as there was a TODO for it in the source code.

[GuitarJ87, 2014-03-17 17:51:38]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto/

[bradfitz, 2014-03-17 18:17:07]

R=agl



On Mon, Mar 17, 2014 at 10:51 AM, <GuitarJ87@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.crypto/
>
>
> Description:
> crypto/openpgp: Adding the ability to encrypt openpgp private keys, as
> there was a TODO for it in the source code.
>
> Please review this at https://codereview.appspot.com/76880044/
>
> Affected files (+223, -1 lines):
>   M openpgp/keys_test.go
>   M openpgp/packet/private_key.go
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[agl1, 2014-05-25 21:09:34]

https://codereview.appspot.com/76880044/diff/40001/openpgp/packet/private_key.go
File openpgp/packet/private_key.go (right):

https://codereview.appspot.com/76880044/diff/40001/openpgp/packet/private_key...
openpgp/packet/private_key.go:196: buf := bytes.NewBuffer(nil)
var buf bytes.Buffer

and s/buf/&buf/

https://codereview.appspot.com/76880044/diff/40001/openpgp/packet/private_key...
openpgp/packet/private_key.go:197: err =
pk.PublicKey.serializeWithoutHeaders(buf)
merge into one line.

https://codereview.appspot.com/76880044/diff/40001/openpgp/packet/private_key...
openpgp/packet/private_key.go:203: Encrypted Serialized PGP Key
tighten up comment - no need to waste blank lines. Might be better as using just
"//"

https://codereview.appspot.com/76880044/diff/40001/openpgp/packet/private_key...
openpgp/packet/private_key.go:222: // Next is Cipher type
give that this is explained above, some of these comments don't carry their
weight.

https://codereview.appspot.com/76880044/diff/40001/openpgp/packet/private_key...
openpgp/packet/private_key.go:241: err = serializeHeader(w, ptype,
len(contents))
merge these lines and just below.

https://codereview.appspot.com/76880044/diff/40001/openpgp/packet/private_key...
openpgp/packet/private_key.go:260: // Using AES256 Cipher
for example, this comment doesn't carry its weight.

https://codereview.appspot.com/76880044/diff/40001/openpgp/packet/private_key...
openpgp/packet/private_key.go:265: conf := Config{}
var conf *Config

(A nil Config works for .Random())

[gobot, 2014-12-19 05:18:30]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/76880044 is best) in the description in your
new CL.

Thanks very much.