Issue 76710043: New architecture utils

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76710043: New architecture utils (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by wallyworld

Modified:
11 years, 3 months ago

Reviewers:
thumper, mp+211232

Visibility:
Public.

Description

New architecture utils Introduce some new architecture utility functions. These will be used by future bootstrap fixes. Also, introduce constants for the various supported architecures and homogenise the supportArches implementation in ec2, openstack, azure providers. https://code.launchpad.net/~wallyworld/juju-core/arch-utils/+merge/211232 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : New architecture utils #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -46 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/plugins/juju-metadata/imagemetadata.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	cmd/plugins/juju-metadata/validatetoolsmetadata.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	constraints/constraints.go	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	environs/imagemetadata/simplestreams.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	environs/manual/init.go	View	1	3 chunks	+4 lines, -24 lines	0 comments	Download
M	environs/tools/tools.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	instance/instance.go	View		2 chunks	+2 lines, -4 lines	0 comments	Download
A	juju/arch/arch.go	View	1	1 chunk	+75 lines, -0 lines	0 comments	Download
A	juju/arch/arch_test.go	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download
A	juju/arch/package_test.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	provider/azure/environ.go	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
M	provider/azure/instancetype.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	provider/ec2/ec2.go	View	1	4 chunks	+8 lines, -2 lines	0 comments	Download
M	provider/ec2/instancetype.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	provider/openstack/provider.go	View	1	4 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

thumper

https://codereview.appspot.com/76710043/diff/1/utils/arch.go File utils/arch.go (right): https://codereview.appspot.com/76710043/diff/1/utils/arch.go#newcode18 utils/arch.go:18: Arch_ppc64 = "ppc64" All good, but not happy with ...

11 years, 3 months ago (2014-03-17 03:40:08 UTC) #2

LGTM

Expand All Messages | Collapse All Messages