Issue 76680043: Issue 1682 : instructorHome.jsp: address eclipse warning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76680043: Issue 1682 : instructorHome.jsp: address eclipse warning

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by edi33416

Modified:
10 months, 3 weeks ago

Reviewers:
leeshawn89

Visibility:
Public.

More Reviews

Description

Issue 1682 : instructorHome.jsp: address eclipse warning

Patch Set 1 #

Total comments: 5

Patch Set 2 : Issue 1682 : instructorHome.jsp: address eclipse #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	src/main/webapp/jsp/instructorHome.jsp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/InstructorHomeHTML.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/InstructorHomeHTMLEmpty.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/InstructorHomeHTMLResponseRateFail.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/InstructorHomeHTMLSortByDate.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/InstructorHomeHTMLSortById.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/InstructorHomeHTMLSortByName.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/instructorHomeCourseArchiveSuccessful.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/instructorHomeCourseDeleteSuccessful.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/instructorHomeEvalDeleteSuccessful.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/instructorHomeHTMLResponseRateEvalPass.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/instructorHomeHTMLResponseRatePass.html	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

leeshawn89

10 years, 6 months ago (2014-03-17 14:30:18 UTC) #1

https://codereview.appspot.com/76680043/diff/1/.project
File .project (right):

https://codereview.appspot.com/76680043/diff/1/.project#newcode34
.project:34: <name>com.google.appengine.eclipse.core.enhancerbuilder</name>
Revert this file to the original if these changes are not required.

https://codereview.appspot.com/76680043/diff/1/src/main/resources/build.prope...
File src/main/resources/build.properties (right):

https://codereview.appspot.com/76680043/diff/1/src/main/resources/build.prope...
src/main/resources/build.properties:1:
#-----------------------------------------------------------------------------
This file is only used by you and should not be committed.

https://codereview.appspot.com/76680043/diff/1/src/main/webapp/WEB-INF/appeng...
File src/main/webapp/WEB-INF/appengine-web.xml (right):

https://codereview.appspot.com/76680043/diff/1/src/main/webapp/WEB-INF/appeng...
src/main/webapp/WEB-INF/appengine-web.xml:3: 
Similar to build.properties, this file is only used by you and should not be
committed.

https://codereview.appspot.com/76680043/diff/1/src/main/webapp/index.html
File src/main/webapp/index.html (right):

https://codereview.appspot.com/76680043/diff/1/src/main/webapp/index.html#new...
src/main/webapp/index.html:11: 
Revert this line if the change this change is not required, since it is only
adding an extra line.

https://codereview.appspot.com/76680043/diff/1/src/test/resources/test.proper...
File src/test/resources/test.properties (right):

https://codereview.appspot.com/76680043/diff/1/src/test/resources/test.proper...
src/test/resources/test.properties:2: # This file contains some configuration
values used during testing.
This file should not be committed as it is for your own use.

Expand All Messages | Collapse All Messages