Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(812)

Issue 76410043: Issue 1635:instructorFeedbackSessionEditQuestion: visibility options don't match the selected recip…

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by franklingujunchao
Modified:
10 years, 6 months ago
Reviewers:
arnold.koroa
Visibility:
Public.

Description

Issue 1635:instructorFeedbackSessionEditQuestion: visibility options don't match the selected recip…

Patch Set 1 #

Patch Set 2 : Issue 1635:instructorFeedbackSessionEditQuestion: visibility options don't match the selected recip… #

Patch Set 3 : Issue 1635:instructorFeedbackSessionEditQuestion: visibility options don't match the selected recip… #

Patch Set 4 : Issue 1635:instructorFeedbackSessionEditQuestion: visibility options don't match the selected recip… #

Total comments: 4

Patch Set 5 : Issue 1635:instructorFeedbackSessionEditQuestion: visibility options don't match the selected recip… #

Patch Set 6 : Issue 1635:instructorFeedbackSessionEditQuestion: visibility options don't match the selected recip… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -170 lines) Patch
M src/main/webapp/js/instructorFeedbackEdit.js View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java View 1 2 3 4 5 14 chunks +196 lines, -168 lines 0 comments Download
M src/test/java/teammates/test/pageobjects/InstructorFeedbackEditPage.java View 1 2 3 4 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 1
arnold.koroa
10 years, 6 months ago (2014-03-20 06:48:39 UTC) #1
https://codereview.appspot.com/76410043/diff/60001/src/test/java/teammates/te...
File
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java
(right):

https://codereview.appspot.com/76410043/diff/60001/src/test/java/teammates/te...
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java:211:
private void testTwoNewEssayQuestionsWithRecipientBeingNobodySpecific() {
indent?

https://codereview.appspot.com/76410043/diff/60001/src/test/java/teammates/te...
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java:220:
// move this to const file
can keep this here for now as it''s only used here. Remove comment or add TODO?

https://codereview.appspot.com/76410043/diff/60001/src/test/java/teammates/te...
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java:223:
feedbackEditPage.numberOfRowsInQuestionTableNewParticipateTable());
indent?

https://codereview.appspot.com/76410043/diff/60001/src/test/java/teammates/te...
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java:228:
}
Maybe also check the content of the rows? It's to ensure we're not hiding the
wrong one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b