Issue 7635045: Use correct metrics for GDI glyphs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7635045: Use correct metrics for GDI glyphs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bungeman

Modified:
11 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 2 : Without debug code. #

Patch Set 3 : Remove unintended change. #

Patch Set 4 : Only double-check for empty when needed. #

Total comments: 2

Patch Set 5 : Comment the matrix. #

Patch Set 6 : The correct CL. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -185 lines)			Patch
	M	src/ports/SkFontHost_win.cpp	View	1 2 3 4 5	9 chunks	+111 lines, -185 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

This is a cleaned up version of https://codereview.chromium.org/12391045/ with some additional changes. The motivation for ...

11 years, 9 months ago (2013-03-08 23:08:29 UTC) #1

reed1

lgtm w/ request for comments around negations https://codereview.appspot.com/7635045/diff/8001/src/ports/SkFontHost_win.cpp File src/ports/SkFontHost_win.cpp (right): https://codereview.appspot.com/7635045/diff/8001/src/ports/SkFontHost_win.cpp#newcode616 src/ports/SkFontHost_win.cpp:616: fMat22.eM12 = ...

11 years, 9 months ago (2013-03-11 12:10:47 UTC) #2

bungeman

11 years, 9 months ago (2013-03-11 19:01:54 UTC) #3

Message was sent while issue was closed.

Committed revision 8069.

https://codereview.appspot.com/7635045/diff/8001/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.appspot.com/7635045/diff/8001/src/ports/SkFontHost_win.cpp...
src/ports/SkFontHost_win.cpp:616: fMat22.eM12 = float2FIXED(-fXform.eM12);
On 2013/03/11 12:10:47, reed1 wrote:
> I think we should have some sort of comment here, or reference to a block
> comment somewhere, detailing why we negate the entries that we do. Same for
the
> code at 637.

Done.

Expand All Messages | Collapse All Messages