Issue 76140044: remove Node.unbind/unbindAll. Node.bindings => Node.bindings_ & only populated by Platform.enableBi…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76140044: remove Node.unbind/unbindAll. Node.bindings => Node.bindings_ & only populated by Platform.enableBi… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rafaelw

Modified:
11 years, 11 months ago

Reviewers:
arv, John Messerly

Base URL:
https://github.com/Polymer/NodeBind.git@master

Visibility:
Public.

More Reviews

Description

remove Node.unbind/unbindAll. Node.bindings => Node.bindings_ & only populated by Platform.enableBindingsReflection(true) R=arv@chromium.org, arv BUG= Committed: https://github.com/Polymer/NodeBind/commit/230d5b2

Patch Set 1 #

Total comments: 4

Patch Set 2 : sync #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -186 lines)			Patch
	M	src/NodeBind.js	View		11 chunks	+28 lines, -52 lines	0 comments	Download
	M	tests/tests.js	View		38 chunks	+71 lines, -134 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

arv

LGTM https://codereview.appspot.com/76140044/diff/1/tests/tests.js File tests/tests.js (right): https://codereview.appspot.com/76140044/diff/1/tests/tests.js#newcode164 tests/tests.js:164: Object.keys(el.bindings_).sort()); strange indentation https://codereview.appspot.com/76140044/diff/1/tests/tests.js#newcode165 tests/tests.js:165: Platform.enableBindingsReflection(false); Should this ...

11 years, 11 months ago (2014-03-15 15:20:12 UTC) #2

rafaelw

https://codereview.appspot.com/76140044/diff/1/tests/tests.js File tests/tests.js (right): https://codereview.appspot.com/76140044/diff/1/tests/tests.js#newcode164 tests/tests.js:164: Object.keys(el.bindings_).sort()); On 2014/03/15 15:20:12, arv wrote: > strange indentation ...

11 years, 11 months ago (2014-03-17 18:49:05 UTC) #3

rafaelw

Committed patchset #2 manually as r230d5b2 (presubmit successful).

11 years, 11 months ago (2014-03-17 20:44:51 UTC) #4

Message was sent while issue was closed.

committed

Expand All Messages | Collapse All Messages