Issue 76100043: Convert comma-separted constraints on ingest.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76100043: Convert comma-separted constraints on ingest.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by bac

Modified:
10 years, 1 month ago

Reviewers:
mp+211067, benji

Visibility:
Public.

Description

Convert comma-separted constraints on ingest. https://code.launchpad.net/~bac/charmworld/fix-constraints-on-ingest/+merge/211067 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -3 lines)			Patch
M	.lbox.check	View	1 chunk	+1 line, -1 line	1 comment	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/jobs/tests/test_ingest.py	View	1 chunk	+4 lines, -2 lines	2 comments	Download
M	charmworld/models.py	View	4 chunks	+27 lines, -0 lines	2 comments	Download
M	charmworld/tests/test_models.py	View	2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benji

LGTM with a couple small suggestions. https://codereview.appspot.com/76100043/diff/1/.lbox.check File .lbox.check (right): https://codereview.appspot.com/76100043/diff/1/.lbox.check#newcode5 .lbox.check:5: make test +100 ...

10 years, 1 month ago (2014-03-14 16:37:39 UTC) #2

bac

10 years, 1 month ago (2014-03-17 13:03:36 UTC) #3

I thought these responses were logged.  Using 'lbox submit', pending RV comments
are sent.  With 'bzr rv-submit' they are not.

https://codereview.appspot.com/76100043/diff/1/charmworld/jobs/tests/test_ing...
File charmworld/jobs/tests/test_ingest.py (right):

https://codereview.appspot.com/76100043/diff/1/charmworld/jobs/tests/test_ing...
charmworld/jobs/tests/test_ingest.py:532: orig_yaml = '{foo: {}}'
ha!

https://codereview.appspot.com/76100043/diff/1/charmworld/models.py
File charmworld/models.py (right):

https://codereview.appspot.com/76100043/diff/1/charmworld/models.py#newcode1866
charmworld/models.py:1866: def massage_bundles_yaml(basket):
On 2014/03/14 16:37:44, benji wrote:
> I suggest we make this specific for now and expand it into a framework for
YAML
> pre-processing in the future if we need it.  E.g., change this function name
to
> "make_constraints_space_separated".

Done.

Expand All Messages | Collapse All Messages