Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5214)

Issue 75980043: fix bug 1243827

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by abel.deuring
Modified:
10 years, 1 month ago
Reviewers:
mp+211015
Visibility:
Public.

Description

fix bug 1243827 If the text of a scalar node of the parsed tree starts with a digit or '+' or '-', the function resolve() removes all '_' from it and tries to convert the new string into a float or integer. When this fails, the variant without the '_' was returned as a string value, which is obviously wrong. I also removed the loop where strings.Replace(in, "_", "", -1) was called with a with a simple of Replace(). This should have the same result but looks a bit simpler. https://code.launchpad.net/~adeuring/goyaml/1243827/+merge/211015 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M decode_test.go View 1 chunk +14 lines, -0 lines 0 comments Download
M resolve.go View 2 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 1
abel.deuring
10 years, 1 month ago (2014-03-14 10:25:53 UTC) #1
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b