Issue 75890043: Issue 1717: studentFeedbackResult: Inform student whether or not they have something new to see

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75890043: Issue 1717: studentFeedbackResult: Inform student whether or not they have something new to see (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by arnold.koroa

Modified:
10 years, 5 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1717: studentFeedbackResult: Inform student whether or not they have something new to see

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -12 lines)			Patch
M	src/main/java/teammates/common/util/Const.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/StudentFeedbackResultsPageAction.java	View	2 chunks	+28 lines, -1 line	1 comment	Download
M	src/test/resources/pages/studentFeedbackResultsPageEmpty.html	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	src/test/resources/pages/studentFeedbackResultsPageMCQ.html	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/test/resources/pages/studentFeedbackResultsPageMSQ.html	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/test/resources/pages/studentFeedbackResultsPageNUMSCALE.html	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/test/resources/pages/studentFeedbackResultsPageOpen.html	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

damith

10 years, 6 months ago (2014-03-14 07:08:39 UTC) #1

https://codereview.appspot.com/75890043/diff/1/src/main/java/teammates/ui/con...
File src/main/java/teammates/ui/controller/StudentFeedbackResultsPageAction.java
(right):

https://codereview.appspot.com/75890043/diff/1/src/main/java/teammates/ui/con...
src/main/java/teammates/ui/controller/StudentFeedbackResultsPageAction.java:56:
private boolean isStudentHasSomethingNewToSee(StudentAttributes student,
FeedbackSessionResultsBundle results) {
this can be a method of FeedbackSessionResultsBundle?

Expand All Messages | Collapse All Messages