Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5269)

Issue 7588043: Make debugger 'text' output less useless. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by bungeman
Modified:
11 years, 3 months ago
Reviewers:
EricB, DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make debugger 'text' output less useless.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M debugger/SkDrawCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M debugger/SkObjectParser.h View 1 chunk +2 lines, -1 line 0 comments Download
M debugger/SkObjectParser.cpp View 2 chunks +46 lines, -5 lines 0 comments Download

Messages

Total messages: 4
bungeman
The real usefulness of this change is that instead of displaying total giberish on all ...
11 years, 3 months ago (2013-03-07 19:41:09 UTC) #1
EricB
LGTM but defer to Derek who probably knows this better than I.
11 years, 3 months ago (2013-03-07 19:50:44 UTC) #2
DerekS
lgtm
11 years, 3 months ago (2013-03-07 20:01:39 UTC) #3
bungeman
11 years, 3 months ago (2013-03-07 20:31:26 UTC) #4
Message was sent while issue was closed.
Committed revision 8029.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b