Issue 75830046: Issue 1702:instructorFeedbackEdit: have a 'Done editing' button?

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by franklingujunchao

Modified:
10 years, 5 months ago

Reviewers:
arnold.koroa

Visibility:
Public.

More Reviews

Description

Issue 1702:instructorFeedbackEdit: have a 'Done editing' button?

Patch Set 2 : Issue 1702:instructorFeedbackEdit: have a 'Done editing' button? #

Total comments: 1

Patch Set 3 : Issue 1702:instructorFeedbackEdit: have a 'Done editing' button? #

Patch Set 4 : Issue 1702:instructorFeedbackEdit: have a 'Done editing' button? #

Total comments: 1

Patch Set 5 : Issue 1702:instructorFeedbackEdit: have a 'Done editing' button? #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+459 lines, -374 lines)			Patch
M	src/main/webapp/jsp/instructorFeedbackEdit.jsp	View	1 2 3 4	40 chunks	+81 lines, -78 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java	View	1 2 3 4	5 chunks	+17 lines, -7 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/InstructorFeedbackEditPage.java	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/InstructorFeedbacksPage.java	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackAddSuccess.html	View	1 2 3 4	19 chunks	+35 lines, -31 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditEmpty.html	View	1 2 3 4	15 chunks	+25 lines, -21 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditPublished.html	View	1 2 3 4	12 chunks	+25 lines, -21 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditSuccess.html	View	1 2 3 4	13 chunks	+20 lines, -16 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMcqQuestionAddSuccess.html	View	1 2 3 4	21 chunks	+43 lines, -39 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMcqQuestionEditSuccess.html	View	1 2 3 4	5 chunks	+9 lines, -4 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMsqQuestionAddSuccess.html	View	1 2 3 4	21 chunks	+43 lines, -39 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMsqQuestionEditSuccess.html	View	1 2 3 4	3 chunks	+7 lines, -2 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackNumScaleQuestionAddSuccess.html	View	1 2 3 4	21 chunks	+43 lines, -39 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackNumScaleQuestionEditSuccess.html	View	1 2 3 4	4 chunks	+8 lines, -3 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackQuestionAddSuccess.html	View	1 2 3 4	19 chunks	+41 lines, -37 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackQuestionEditSuccess.html	View	1 2 3 4	19 chunks	+41 lines, -37 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackQuestionEditToTeamToTeam.html	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackQuestionVisibilityOptions.html	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

arnold.koroa

https://codereview.appspot.com/75830046/diff/20001/src/main/webapp/jsp/instructorFeedbackEdit.jsp File src/main/webapp/jsp/instructorFeedbackEdit.jsp (right): https://codereview.appspot.com/75830046/diff/20001/src/main/webapp/jsp/instructorFeedbackEdit.jsp#newcode503 src/main/webapp/jsp/instructorFeedbackEdit.jsp:503: <a href="../page/instructorFeedbacksPage?user=<%=data.account.googleId%>&courseid=<%=data.session.courseId%>" class="button">Done Editing</a> use the constant available at ...

10 years, 5 months ago (2014-03-20 03:00:33 UTC) #1

arnold.koroa

10 years, 5 months ago (2014-03-21 03:36:11 UTC) #2

https://codereview.appspot.com/75830046/diff/60001/src/main/webapp/jsp/instru...
File src/main/webapp/jsp/instructorFeedbackEdit.jsp (right):

https://codereview.appspot.com/75830046/diff/60001/src/main/webapp/jsp/instru...
src/main/webapp/jsp/instructorFeedbackEdit.jsp:503: <a href="<%=".." +
Const.ActionURIs.INSTRUCTOR_FEEDBACKS_PAGE + "?" + Const.ParamsNames.USER_ID +
"=" + data.account.googleId + "&" + Const.ParamsNames.COURSE_ID + "=" +
data.session.courseId%>" class="button">Done Editing</a>
There's no need for the ".." as the site structure is handled by the
ActionFactory

Expand All Messages | Collapse All Messages