Issue 75700043: Omit empty proxy settings in config.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75700043: Omit empty proxy settings in config.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by thumper

Modified:
10 years, 1 month ago

Reviewers:
axw, mp+210952

Visibility:
Public.

Description

Omit empty proxy settings in config. I had changed them to default to "" because there is no way to unset the value once you have set one for an environment. The correct fix is to implement 'juju unset-env' https://code.launchpad.net/~thumper/juju-core/proxy-config-omit/+merge/210952 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -16 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config/config.go	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	environs/config/config_test.go	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

10 years, 1 month ago (2014-03-14 02:24:55 UTC) #2

On 2014/03/14 02:23:33, thumper wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages