Issue 7568046: Use unparsed_uri to build Sec-WebSocket-Location header.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7568046: Use unparsed_uri to build Sec-WebSocket-Location header. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by tyoshino (chromium.org)

Modified:
12 years, 11 months ago

Reviewers:
Adam Rice

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Use unparsed_uri to build Sec-WebSocket-Location header. Release note: Changed Sec-WebSocket-Location to include the query part. BUG= https://code.google.com/p/pywebsocket/issues/detail?id=68 Committed: 741

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -49 lines)			Patch
M	src/mod_pywebsocket/handshake/_base.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mod_pywebsocket/handshake/hybi00.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mod_pywebsocket/standalone.py	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	src/test/mock.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/test/test_handshake_hybi00.py	View	1	21 chunks	+107 lines, -46 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Adam Rice

lgtm https://codereview.appspot.com/7568046/diff/1/src/mod_pywebsocket/handshake/_base.py File src/mod_pywebsocket/handshake/_base.py (right): https://codereview.appspot.com/7568046/diff/1/src/mod_pywebsocket/handshake/_base.py#newcode109 src/mod_pywebsocket/handshake/_base.py:109: fields = request.headers_in[common.HOST_HEADER].split(':', 1) Just checking: is this ...

12 years, 11 months ago (2013-03-15 12:07:24 UTC) #2

tyoshino (chromium.org)

https://codereview.appspot.com/7568046/diff/1/src/mod_pywebsocket/handshake/_base.py File src/mod_pywebsocket/handshake/_base.py (right): https://codereview.appspot.com/7568046/diff/1/src/mod_pywebsocket/handshake/_base.py#newcode109 src/mod_pywebsocket/handshake/_base.py:109: fields = request.headers_in[common.HOST_HEADER].split(':', 1) On 2013/03/15 12:07:24, Adam Rice ...

12 years, 11 months ago (2013-03-15 12:27:37 UTC) #3

tyoshino (chromium.org)

12 years, 11 months ago (2013-03-18 06:25:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r741 (presubmit successful).

Expand All Messages | Collapse All Messages