Issue 75680043: Fix the permissions on the tools dir on upgrade

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75680043: Fix the permissions on the tools dir on upgrade

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by thumper

Modified:
10 years, 1 month ago

Reviewers:
mp+210951, axw

Visibility:
Public.

Description

Fix the permissions on the tools dir on upgrade The tempdir was created with 0700, and then renamed to be the tools dir. Now we chmod to 0755 prior to rename. https://code.launchpad.net/~thumper/juju-core/upgrade-fix-juju-run/+merge/210951 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	agent/tools/diskmanager_test.go	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	agent/tools/toolsdir.go	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

10 years, 1 month ago (2014-03-14 01:23:20 UTC) #2

On 2014/03/14 01:20:53, thumper wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages