Issue 7559043: Change set_use_system_keyboard_layout() timing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7559043: Change set_use_system_keyboard_layout() timing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by fujiwara

Modified:
11 years, 3 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Change set_use_system_keyboard_layout() timing. Call set_use_system_keyboard_layout() before update_engines() is called in panel.vala because update_engines() calls switch_engine(). BUG=http://code.google.com/p/ibus/issues/detail?id=1558#c43

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ui/gtk3/panel.vala	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peng

11 years, 3 months ago (2013-03-07 03:51:33 UTC) #2

LGTM. But the CL description is not very useful. Could you please put more
detail in it. Thanks.

Expand All Messages | Collapse All Messages