Add ServiceDestroyUnits to the API

cmd/juju/destroyunit.go

 package main
 
 import (
         "errors"
         "fmt"
         "launchpad.net/juju-core/cmd"
         "launchpad.net/juju-core/juju"
         "launchpad.net/juju-core/state"
+        "launchpad.net/juju-core/state/api/params"
+        "launchpad.net/juju-core/state/statecmd"
 )
 
 // DestroyUnitCommand is responsible for destroying service units.
 type DestroyUnitCommand struct {
         EnvCommandBase
         UnitNames []string
 }
 
 func (c *DestroyUnitCommand) Info() *cmd.Info {
         return &cmd.Info{
@@ skipping 10 matching lines @@
                 return errors.New("no units specified")
         }
         for _, name := range c.UnitNames {
                 if !state.IsUnitName(name) {
                         return fmt.Errorf("invalid unit name %q", name)
                 }
         }
         return nil
 }
 
-// Run connects to the environment specified on the command line
-// and calls conn.DestroyUnits.
+// DestroyUnitCommand connects to the environment specified on the command line

[dimitern, 2013/03/14 14:18:49]

It's still Run(), so it starts with // Run ... . Probably move the more general
comment to the struct doc comment?

[benji, 2013/03/15 13:39:12]

Good catch, I'm still not used to reading Go's function signatures.

This class of error would be caught by a good linter.  Is there such a thing for
Go?

[dimitern, 2013/03/15 13:52:36]

Not that I know of, probably some quick research is in order. If there is
indeed, I'd gladly use it!

[benji, 2013/03/15 14:16:32]

My search has found only an incomplete and abandoned linter.  For this use case
(linting docstrings) we could probably put something together relatively easily.
 The juju-gui team built a small yuidoc linter for use on that project.

+// and calls destroys units therein.
 func (c *DestroyUnitCommand) Run(_ *cmd.Context) (err error) {
         conn, err := juju.NewConnFromName(c.EnvName)
         if err != nil {
                 return err
         }
         defer conn.Close()
-        return conn.DestroyUnits(c.UnitNames...)
+        params := params.ServiceDestroyUnits{
+                UnitNames: c.UnitNames,
+        }
+        return statecmd.ServiceDestroyUnits(conn.State, params)
 }