Issue 7531047: Fix build error and warnings in Fedora 18.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7531047: Fix build error and warnings in Fedora 18. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by Peng

Modified:
11 years, 3 months ago

Reviewers:
Daiki Ueno, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix build error and warnings in Fedora 18. BUG=None TEST=Manual Committed: 47d90f5 Committed: 0029abe

Patch Set 2 : Update #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -23 lines)			Patch
M	bus/dbusimpl.c	View		7 chunks	+17 lines, -14 lines	0 comments	Download
M	bus/main.c	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	client/gtk2/ibusimcontext.c	View		3 chunks	+9 lines, -2 lines	0 comments	Download
M	configure.ac	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ibus.spec.in	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peng

Please take a look. https://codereview.appspot.com/7531047/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/7531047/diff/1/configure.ac#newcode54 configure.ac:54: m4_define([glib_required_version], [2.32.0]) Is this change ...

11 years, 3 months ago (2013-03-25 15:41:42 UTC) #1

fujiwara

11 years, 3 months ago (2013-03-26 07:08:41 UTC) #2

lgtm

https://codereview.appspot.com/7531047/diff/1/configure.ac
File configure.ac (right):

https://codereview.appspot.com/7531047/diff/1/configure.ac#newcode54
configure.ac:54: m4_define([glib_required_version], [2.32.0])
On 2013/03/25 15:41:42, Peng wrote:
> Is this change safe?

Probably the change is ok to focus on GNOME 3.

Expand All Messages | Collapse All Messages