Issue 7531043: Add a map from index to SkFlatData* in SkFlatDictionary

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7531043: Add a map from index to SkFlatData* in SkFlatDictionary (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by robertphillips

Modified:
11 years, 7 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This is a left-over TODO from the SkPictureRecord task. It removes the need to a linear search in SkFlatDictionary::unflatten.

Patch Set 2 : Addressed code review issues #

Patch Set 3 : Fixed/added asserts #

Patch Set 4 : Improved comment #

Patch Set 5 : Fixed bug #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -34 lines)			Patch
	M	src/core/SkPictureFlat.h	View	1 2 3 4	10 chunks	+49 lines, -33 lines	0 comments	Download
	M	src/core/SkPictureFlat.cpp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

reed1

https://codereview.appspot.com/7531043/diff/1/src/core/SkPictureFlat.h File src/core/SkPictureFlat.h (right): https://codereview.appspot.com/7531043/diff/1/src/core/SkPictureFlat.h#newcode406 src/core/SkPictureFlat.h:406: fMap.push(NULL); // 0 always maps to NULL Yes 0 ...

11 years, 7 months ago (2013-03-07 21:26:30 UTC) #3

robertphillips

Hopefully clearer https://codereview.appspot.com/7531043/diff/1/src/core/SkPictureFlat.h File src/core/SkPictureFlat.h (right): https://codereview.appspot.com/7531043/diff/1/src/core/SkPictureFlat.h#newcode406 src/core/SkPictureFlat.h:406: fMap.push(NULL); // 0 always maps to NULL ...

11 years, 7 months ago (2013-03-08 19:33:13 UTC) #4

Message was sent while issue was closed.

committed as r8060

Expand All Messages | Collapse All Messages