Issue 75310043: Issue 1663:[GOAL] Support commenting on feedback responses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75310043: Issue 1663:[GOAL] Support commenting on feedback responses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by arnold.koroa

Modified:
10 years, 7 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1663:[GOAL] Support commenting on feedback responses

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4521 lines, -1809 lines)			Patch
M	src/main/java/teammates/common/datatransfer/DataBundle.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/main/java/teammates/common/datatransfer/FeedbackResponseCommentAttributes.java	View	1 chunk	+126 lines, -0 lines	1 comment	Download
M	src/main/java/teammates/common/datatransfer/FeedbackSessionResultsBundle.java	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	src/main/java/teammates/common/util/Const.java	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	src/main/java/teammates/logic/api/Logic.java	View	7 chunks	+42 lines, -3 lines	0 comments	Download
M	src/main/java/teammates/logic/backdoor/BackDoorLogic.java	View	5 chunks	+48 lines, -2 lines	0 comments	Download
M	src/main/java/teammates/logic/core/CommentsLogic.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/main/java/teammates/logic/core/FeedbackResponseCommentsLogic.java	View	1 chunk	+56 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/logic/core/FeedbackSessionsLogic.java	View	7 chunks	+33 lines, -5 lines	0 comments	Download
A	src/main/java/teammates/storage/api/FeedbackResponseCommentsDb.java	View	1 chunk	+186 lines, -0 lines	0 comments	Download
A	src/main/java/teammates/storage/entity/FeedbackResponseComment.java	View	1 chunk	+142 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/ActionFactory.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	src/main/java/teammates/ui/controller/InstructorFeedbackResponseCommentAddAction.java	View	1 chunk	+86 lines, -0 lines	0 comments	Download
A	src/main/java/teammates/ui/controller/InstructorFeedbackResponseCommentDeleteAction.java	View	1 chunk	+51 lines, -0 lines	0 comments	Download
A	src/main/java/teammates/ui/controller/InstructorFeedbackResponseCommentEditAction.java	View	1 chunk	+76 lines, -0 lines	0 comments	Download
A	src/main/webapp/js/feedbackResponseComments.js	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/main/webapp/jsp/instructorFeedbackResultsByRecipient.jsp	View	3 chunks	+82 lines, -0 lines	0 comments	Download
M	src/main/webapp/jsp/instructorStudentRecords.jsp	View	3 chunks	+47 lines, -0 lines	0 comments	Download
M	src/main/webapp/jsp/studentFeedbackResults.jsp	View	5 chunks	+29 lines, -8 lines	0 comments	Download
M	src/main/webapp/stylesheets/common.css	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	src/test/java/teammates/test/cases/ui/InstructorFeedbackResponseCommentAddActionTest.java	View	1 chunk	+127 lines, -0 lines	0 comments	Download
A	src/test/java/teammates/test/cases/ui/InstructorFeedbackResponseCommentDeleteActionTest.java	View	1 chunk	+114 lines, -0 lines	0 comments	Download
A	src/test/java/teammates/test/cases/ui/InstructorFeedbackResponseCommentEditActionTest.java	View	1 chunk	+133 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackResultsPageUiTest.java	View	3 chunks	+28 lines, -3 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorStudentRecordsPageUiTest.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/StudentFeedbackResultsPageUiTest.java	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/InstructorFeedbackResultsPage.java	View	3 chunks	+38 lines, -0 lines	0 comments	Download
M	src/test/resources/data/InstructorStudentRecordsPageUiTest.json	View	1 chunk	+790 lines, -607 lines	0 comments	Download
M	src/test/resources/data/MashupPageUiTest.json	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	src/test/resources/data/StudentFeedbackResultsPageUiTest.json	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/test/resources/data/typicalDataBundle.json	View	28 chunks	+69 lines, -17 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsPageEmpty.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsPageOpen.html	View	9 chunks	+987 lines, -532 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsSortRecipient.html	View	6 chunks	+1031 lines, -576 lines	0 comments	Download
M	src/test/resources/pages/instructorStudentRecordsPage.html	View	1 chunk	+24 lines, -1 line	0 comments	Download
M	src/test/resources/pages/studentFeedbackResultsPageMCQ.html	View	6 chunks	+6 lines, -13 lines	0 comments	Download
M	src/test/resources/pages/studentFeedbackResultsPageMSQ.html	View	6 chunks	+8 lines, -10 lines	0 comments	Download
M	src/test/resources/pages/studentFeedbackResultsPageNUMSCALE.html	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	src/test/resources/pages/studentFeedbackResultsPageOpen.html	View	7 chunks	+32 lines, -18 lines	0 comments	Download
M	src/test/testng.xml	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

damith

10 years, 7 months ago (2014-03-14 04:09:26 UTC) #1

https://codereview.appspot.com/75310043/diff/1/src/main/java/teammates/common...
File
src/main/java/teammates/common/datatransfer/FeedbackResponseCommentAttributes.java
(right):

https://codereview.appspot.com/75310043/diff/1/src/main/java/teammates/common...
src/main/java/teammates/common/datatransfer/FeedbackResponseCommentAttributes.java:13:

header comment?

Expand All Messages | Collapse All Messages