Issue 7516045: Prepare for 1.1 release.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7516045: Prepare for 1.1 release. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by jcgregorio_google

Modified:
13 years ago

Reviewers:
jcgregorio_google, dhermes

CC:
google-api-python-client_googlegroups.com, proppy

Visibility:
Public.

More Reviews

Patch Set 4 : typo #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
M	CHANGELOG	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	apiclient/__init__.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	oauth2client/__init__.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	setup.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	setup_oauth2client.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dhermes

LGTM https://codereview.appspot.com/7516045/diff/2001/CHANGELOG File CHANGELOG (right): https://codereview.appspot.com/7516045/diff/2001/CHANGELOG#newcode27 CHANGELOG:27: - HMAC verification does not use a cosntant ...

13 years ago (2013-03-06 21:26:30 UTC) #3

jcgregorio_google

13 years ago (2013-03-07 16:50:08 UTC) #4

Committed at
https://code.google.com/p/google-api-python-client/source/detail?r=1454877540...

https://codereview.appspot.com/7516045/diff/2001/CHANGELOG
File CHANGELOG (right):

https://codereview.appspot.com/7516045/diff/2001/CHANGELOG#newcode27
CHANGELOG:27: - HMAC verification does not use a cosntant time algorithm.
On 2013/03/06 21:26:30, dhermes wrote:
> s/cosntant/constant

Done.

Expand All Messages | Collapse All Messages