Issue 7506043: Remove circular dependency.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7506043: Remove circular dependency. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by jcgregorio_google

Modified:
11 years, 6 months ago

Reviewers:
proppy

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Remove circular dependency. discovery._add_query_parameter was being called from oauth2client. Moved it to oauth2client.util.

Patch Set 1 #

Total comments: 4

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -26 lines)			Patch
M	apiclient/discovery.py	View	2 chunks	+1 line, -23 lines	4 comments	Download
M	oauth2client/appengine.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	oauth2client/util.py	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	tests/test_discovery.py	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

proppy

LGTM, just remove unused import (lint?) https://codereview.appspot.com/7506043/diff/1/apiclient/discovery.py File apiclient/discovery.py (left): https://codereview.appspot.com/7506043/diff/1/apiclient/discovery.py#oldcode35 apiclient/discovery.py:35: import urllib unused ...

11 years, 6 months ago (2013-03-06 14:45:46 UTC) #3

jcgregorio_google

11 years, 6 months ago (2013-03-06 14:47:31 UTC) #4

Actually all those imports are used.

On 2013/03/06 14:45:46, proppy wrote:
> LGTM, just remove unused import (lint?)
> 
> https://codereview.appspot.com/7506043/diff/1/apiclient/discovery.py
> File apiclient/discovery.py (left):
> 
> https://codereview.appspot.com/7506043/diff/1/apiclient/discovery.py#oldcode35
> apiclient/discovery.py:35: import urllib
> unused import
> 
> https://codereview.appspot.com/7506043/diff/1/apiclient/discovery.py#oldcode36
> apiclient/discovery.py:36: import urlparse
> unused import
> 
> https://codereview.appspot.com/7506043/diff/1/apiclient/discovery.py#oldcode41
> apiclient/discovery.py:41: from urlparse import parse_qsl
> unused import
> 
> https://codereview.appspot.com/7506043/diff/1/apiclient/discovery.py#oldcode43
> apiclient/discovery.py:43: from cgi import parse_qsl
> unused import

Expand All Messages | Collapse All Messages