Issue 7486052: Making SkDrawCommand more robust

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7486052: Making SkDrawCommand more robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by robertphillips

Modified:
11 years, 9 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

We still have crashes when using SaveAs in the debugger. This CL makes the debugCanvas a bit more robust to having its supporting SkPicture deleted out from under it.

Patch Set 3 : Addressed code review issues #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -64 lines)			Patch
M	debugger/SkDrawCommand.h	View	1 2	6 chunks	+26 lines, -14 lines	0 comments	Download
M	debugger/SkDrawCommand.cpp	View	1 2	4 chunks	+55 lines, -49 lines	0 comments	Download
M	tools/filtermain.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

DerekS

https://codereview.appspot.com/7486052/diff/2001/debugger/SkDrawCommand.cpp File debugger/SkDrawCommand.cpp (right): https://codereview.appspot.com/7486052/diff/2001/debugger/SkDrawCommand.cpp#newcode237 debugger/SkDrawCommand.cpp:237: fSrcPtr = NULL; fSrc.setEmpty() ?

11 years, 9 months ago (2013-03-14 16:29:00 UTC) #2

robertphillips

11 years, 9 months ago (2013-03-14 18:34:35 UTC) #3

Message was sent while issue was closed.

committed as r8181

Expand All Messages | Collapse All Messages