src/pkg/net/sock_linux.go - Issue 7480046: code review 7480046: net: never use backlog > 65535

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/net/sock_linux.go

Issue 7480046: code review 7480046: net: never use backlog > 65535 (Closed)

Patch Set: diff -r 7b6b3b170d9a https://code.google.com/p/go/ Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/net/sock_linux.go

===================================================================

--- a/src/pkg/net/sock_linux.go

+++ b/src/pkg/net/sock_linux.go

@@ -21,5 +21,11 @@

if n == 0 || !ok {

return syscall.SOMAXCONN

}

+ // Linux stores the backlog in a uint16.

+ // Truncate number to avoid wrapping.

+ // See issue 5030.

+ if n > 1<<16-1 {

+ n = 1<<16 - 1

+ }

return n

}

« no previous file with comments | « src/pkg/net/sock_bsd.go ('k') | src/pkg/net/sock_windows.go » ('j') | no next file with comments »