Issue 7466044: Add a fast path for BGRA to RGBA conversion inside readPixels

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7466044: Add a fast path for BGRA to RGBA conversion inside readPixels

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by Evan Wallace

Modified:
11 years, 1 month ago

Reviewers:
shannon.woods, nicolas

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add a fast path for BGRA to RGBA conversion inside readPixels. Already covered by existing WebGL conformance tests. 5x speedup observed for reading back a 4096x4096x4 texture on a NVIDIA GeForce 9600M GT (from 1000ms to 200ms).

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/libGLESv2/Context.cpp	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nicolas

Looks good to me. Please complete the CLA if you haven't done so already: https://code.google.com/p/angleproject/wiki/ContributingCode ...

11 years, 1 month ago (2013-03-05 17:03:44 UTC) #2

Evan Wallace

11 years, 1 month ago (2013-03-05 17:57:58 UTC) #3

On 2013/03/05 17:03:44, nicolas wrote:
> Looks good to me. Please complete the CLA if you haven't done so already:
> https://code.google.com/p/angleproject/wiki/ContributingCode
> 
> Thanks!

Thanks for the review. I've signed the CLA and emailed Shannon.

Expand All Messages | Collapse All Messages