Issue 7444053: Initialize grid info in TiledPictureRenderer::init

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7444053: Initialize grid info in TiledPictureRenderer::init (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by robertphillips

Modified:
11 years, 6 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, junov

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Justin would be the natural reviewer for this but he is out. It appears this is why the Windows RenderPictures tests are dying. Please compare with the skipped initialization in PictureRenderer:init and SimplePictureRenderer::init().

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tools/PictureRenderer.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

11 years, 6 months ago (2013-03-02 17:48:15 UTC) #4

Message was sent while issue was closed.

Relanded as 7942 (https://codereview.appspot.com/7435052/)

Expand All Messages | Collapse All Messages