Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2063)

Issue 7441044: Update build scripts to use new commands. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Leon
Modified:
11 years, 8 months ago
Reviewers:
EricB
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/buildbot
Visibility:
Public.

Description

Update build scripts to use new commands. https://codereview.appspot.com/7230053/ changes the flag format, so update the bots to use the new format: Pass '-i' before the skp directory. '--logPerIter' no longer needs a '1' after it, so remove it. Use '--device' instead of '--config', and '8888' instead of 'bitmap'. Closed in favor of https://codereview.appspot.com/7449047/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M slave/skia_slave_scripts/android_render_pictures.py View 1 chunk +1 line, -1 line 0 comments Download
M slave/skia_slave_scripts/render_pictures.py View 2 chunks +3 lines, -3 lines 0 comments Download
M slave/skia_slave_scripts/render_webpage_pictures.py View 1 chunk +1 line, -1 line 0 comments Download
M slave/skia_slave_scripts/run_bench.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Leon
Eric, I think these are the right things to change, but please let me know ...
11 years, 8 months ago (2013-02-28 17:17:52 UTC) #1
EricB
Thanks for taking this on. It all looks right to me, but I have a ...
11 years, 8 months ago (2013-02-28 20:45:34 UTC) #2
Leon
On 2013/02/28 20:45:34, EricB wrote: > Thanks for taking this on. It all looks right ...
11 years, 8 months ago (2013-03-01 01:38:14 UTC) #3
EricB
11 years, 8 months ago (2013-03-01 13:40:36 UTC) #4
On 2013/03/01 01:38:14, Leon wrote:
> On 2013/02/28 20:45:34, EricB wrote:
> > Thanks for taking this on.  It all looks right to me, but I have a couple of
> > suggestions to make sure:
> > 1. Run a try with your other change, making sure you hit the major groups:
> > debug/bench, desktop/android/chromeos.  I suspect you'll need to make some
> > changes for Android and ChromeOS as well.
> > 2. Tomorrow morning I will submit a major refactor to these scripts.  Once
> that
> > is merged, separate flags for Android and ChromeOS will no longer be an
issue.
> 
> > It might be less complicated if you can wait until then.
> 
> Sounds like a good plan. I'll wait for your merge (please cc me on the code
> review), and then I'll run a try with my other change.

I just saw this.  The change has already been committed:
https://code.google.com/p/skia/source/detail?r=7911
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b