Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158)

Issue 744: [issue1736190] asyncore/asynchat patches (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by GvR
Modified:
8 years, 5 months ago
Reviewers:
josiah.carlson, report
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/
Visibility:
Public.

Description

http://bugs.python.org/issue1736190 This is now checked in.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -105 lines) Patch
Doc/library/asynchat.rst View 2 chunks +12 lines, -0 lines 0 comments Download
Doc/library/asyncore.rst View 1 chunk +14 lines, -0 lines 2 comments Download
Lib/asynchat.py View 3 chunks +72 lines, -58 lines 0 comments Download
Lib/asyncore.py View 15 chunks +114 lines, -47 lines 0 comments Download
Lib/test/test_asyncore.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
GvR
(This is mostly a test of the bug/rietveld integration.) http://codereview.appspot.com/744/diff/1/22 File Doc/library/asyncore.rst (right): http://codereview.appspot.com/744/diff/1/22#newcode226 Line ...
9 years, 8 months ago (2008-05-05 22:02:22 UTC) #1
josiah.carlson
9 years, 8 months ago (2008-05-21 19:09:42 UTC) #2
http://codereview.appspot.com/744/diff/1/22
File Doc/library/asyncore.rst (right):

http://codereview.appspot.com/744/diff/1/22#newcode226
Line 226: A file_dispatcher takes a file descriptor or file object along with an
optional
On 2008/05/05 22:02:22, GvR wrote:
> Mind keeping the line length under 80 chars?

No problem.  Any other comments?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d