Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(280)

Issue 7438047: Add flags to describe.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by jcgregorio_google
Modified:
11 years, 6 months ago
Reviewers:
dhermes
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Description

Add flags to describe.py

Patch Set 1 #

Patch Set 2 : 80 chars #

Total comments: 6

Patch Set 3 : comments #

Patch Set 4 : 80 chars #

Patch Set 5 : 80 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M describe.py View 1 2 3 4 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6
jcgregorio_google
11 years, 6 months ago (2013-02-28 20:35:33 UTC) #1
jcgregorio_google
11 years, 6 months ago (2013-02-28 20:35:44 UTC) #2
dhermes
https://codereview.appspot.com/7438047/diff/2001/describe.py File describe.py (right): https://codereview.appspot.com/7438047/diff/2001/describe.py#newcode132 describe.py:132: DISCOVERY_URI = ('https://www.googleapis.com/discovery/v1/apis/' Why not import this from apiclient.discovery? ...
11 years, 6 months ago (2013-02-28 20:59:52 UTC) #3
jcgregorio_google
https://codereview.appspot.com/7438047/diff/2001/describe.py File describe.py (right): https://codereview.appspot.com/7438047/diff/2001/describe.py#newcode132 describe.py:132: DISCOVERY_URI = ('https://www.googleapis.com/discovery/v1/apis/' On 2013/02/28 20:59:52, dhermes wrote: > ...
11 years, 6 months ago (2013-03-01 17:22:49 UTC) #4
dhermes
LGTM
11 years, 6 months ago (2013-03-02 00:28:21 UTC) #5
jcgregorio_google
11 years, 6 months ago (2013-03-04 01:47:54 UTC) #6
On 2013/03/02 00:28:21, dhermes wrote:
> LGTM

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=a1a14a7850...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b