code review 74370043: doc: Revise Contribution Guidelines.

doc: Revise Contribution Guidelines.

Smooth out the setup process for new contributors.

* Remove references $GOROOT (often not defined).
* Add a note for contributing to subrepositories.
* Emphasize that hg mail also uploads the latest copy.

[nathany, 2014-03-12 02:49:36]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-03-12 04:03:12]

https://codereview.appspot.com/74370043/diff/40001/doc/contribute.html
File doc/contribute.html (right):

https://codereview.appspot.com/74370043/diff/40001/doc/contribute.html#newcod...
doc/contribute.html:499: <p>again to <em>upload the latest copy and send
mail</em> asking the reviewers to please take another look
I don't think these <em> are well placed.  To emphasize the point that hg mail
uploads, how about not using the <em>, and instead writing a separate sentence.

run

$ hg mail 99999

This will upload the latest copy of the code, and then send mail asking the
reviewers to please take another look.

[nathany, 2014-03-12 04:43:29]

Thanks. Revising the text is certainly better than just adding emphasis.

When I first read this document, my problem was that I thought I already
understood "hg mail" based on the previous section. I ended up skimming
past this, not noticing that mail also uploads.

To be clear, hg mail is a shortcut to hg upload and comment PTAL, but is it
required after hg change?

It seems to be, yet I always seem to have more revisions uploaded than
I expect.

Nathan.


On Tuesday, March 11, 2014, <iant@golang.org> wrote:

>
> https://codereview.appspot.com/74370043/diff/40001/doc/contribute.html
> File doc/contribute.html (right):
>
> https://codereview.appspot.com/74370043/diff/40001/doc/
> contribute.html#newcode499
> doc/contribute.html:499: <p>again to <em>upload the latest copy and send
> mail</em> asking the reviewers to please take another look
> I don't think these <em> are well placed.  To emphasize the point that
> hg mail uploads, how about not using the <em>, and instead writing a
> separate sentence.
>
> run
>
> $ hg mail 99999
>
> This will upload the latest copy of the code, and then send mail asking
> the reviewers to please take another look.
>
> https://codereview.appspot.com/74370043/
>


-- 
Nathan Youngman
Email: nj@nathany.com
Web: http://www.nathany.com

[iant, 2014-03-12 04:50:56]

On Tue, Mar 11, 2014 at 9:43 PM, Nathan Youngman <nj@nathany.com> wrote:
>
> To be clear, hg mail is a shortcut to hg upload and comment PTAL, but is it
> required after hg change?

It's not required, in the sense that you can also do "hg upload" and
then send mail in the codereview app.  But it's a convenient way to
upload the change and send a new e-mail about it.

Ian

[nathany, 2014-03-12 05:19:41]

On 2014/03/12 04:03:12, iant wrote:
> run
> 
> $ hg mail 99999
> 
> This will upload the latest copy of the code, and then send mail asking the
> reviewers to please take another look.

I put "hg mail" first, as the more common option, and so it doesn't look like a
sequence (upload & mail as with hg change & mail).

Starting the line between them with "Or" will hopefully make it clear that these
are alternatives, even to those quickly scanning the text.

[nathany, 2014-03-15 03:12:38]

Hello golang-codereviews@googlegroups.com, iant@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[adg, 2014-03-16 22:34:10]

LGTM

[adg, 2014-03-16 22:36:03]

Submitted but failed to close the issue because of a network issue:
http://code.google.com/p/go/source/detail?r=32b8c26e4414

[gobot, 2014-03-16 23:37:10]

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/bd8a434c0b36ddd8d27e3696c62283c960a1a1d9

[nathany, 2014-05-29 03:20:06]

*** Abandoned ***