Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1251)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7436045: Split GrGLContextInfo into GrGLContext & GrGLContextInfo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by robertphillips
Modified:
11 years, 4 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

I don't know if it is worth renaming all the SkGLContextHelper-derived classes.

Patch Set 1 #

Patch Set 2 : fixed typos #

Patch Set 3 : fixed typos #

Patch Set 4 : Add missing/renamed files #

Patch Set 5 : add missing/renamed files (take 2) #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -597 lines) Patch
M bench/BenchGpuTimer_gl.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M bench/BenchGpuTimer_gl.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M bench/BenchTimer.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M bench/BenchTimer.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M bench/benchmain.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M include/gpu/GrContextFactory.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/gl/SkANGLEGLContext.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/gl/SkDebugGLContext.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D include/gpu/gl/SkGLContext.h View 1 2 3 1 chunk +0 lines, -77 lines 0 comments Download
A + include/gpu/gl/SkGLContextHelper.h View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M include/gpu/gl/SkMesaGLContext.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/gl/SkNativeGLContext.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/gl/SkNullGLContext.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpuFactory.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
src/gpu/gl/GrGLCaps.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 6 chunks +7 lines, -10 lines 0 comments Download
A + src/gpu/gl/GrGLContext.h View 1 2 3 4 chunks +58 lines, -26 lines 2 comments Download
A + src/gpu/gl/GrGLContext.cpp View 1 2 3 3 chunks +54 lines, -47 lines 0 comments Download
D src/gpu/gl/GrGLContextInfo.h View 1 2 3 1 chunk +0 lines, -89 lines 0 comments Download
D src/gpu/gl/GrGLContextInfo.cpp View 1 2 3 1 chunk +0 lines, -81 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 3 13 chunks +17 lines, -17 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 2 3 8 chunks +10 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLUniformManager.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 3 6 chunks +12 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 8 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/gl/SkGLContext.cpp View 1 2 3 1 chunk +0 lines, -139 lines 0 comments Download
A + src/gpu/gl/SkGLContextHelper.cpp View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/PdfRenderer.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tools/PictureRenderer.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
robertphillips
11 years, 4 months ago (2013-02-28 20:05:22 UTC) #1
bsalomon
Minor question about friend vs public. Otherwise, lgtm. https://codereview.appspot.com/7436045/diff/6002/src/gpu/gl/GrGLContext.h File src/gpu/gl/GrGLContext.h (right): https://codereview.appspot.com/7436045/diff/6002/src/gpu/gl/GrGLContext.h#newcode62 src/gpu/gl/GrGLContext.h:62: friend ...
11 years, 4 months ago (2013-02-28 20:11:47 UTC) #2
robertphillips
11 years, 4 months ago (2013-02-28 20:16:56 UTC) #3
Message was sent while issue was closed. 
committed as r7905

https://codereview.appspot.com/7436045/diff/6002/src/gpu/gl/GrGLContext.h
File src/gpu/gl/GrGLContext.h (right):

https://codereview.appspot.com/7436045/diff/6002/src/gpu/gl/GrGLContext.h#new...
src/gpu/gl/GrGLContext.h:62: friend class GrGLContext;   // for access to reset
On 2013/02/28 20:11:47, bsalomon wrote:
> Should we just make reset public?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b