Issue 7435050: Disable ibus input context when QLineEdit is password mode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7435050: Disable ibus input context when QLineEdit is password mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by fujiwara

Modified:
12 years, 11 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus-qt.git@master

Visibility:
Public.

More Reviews

Description

Disable ibus input context when QLineEdit is password mode. Apply a similar fix with ibus gtk+ modules. BUG=http://code.google.com/p/ibus/issues/detail?id=1599

Patch Set 2 : Updated with message #2. #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	qtim/ibus-input-context.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	qtim/ibus-input-context.cpp	View	1	4 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm with one comment https://codereview.appspot.com/7435050/diff/1/qtim/ibus-input-context.cpp File qtim/ibus-input-context.cpp (right): https://codereview.appspot.com/7435050/diff/1/qtim/ibus-input-context.cpp#newcode204 qtim/ibus-input-context.cpp:204: QLineEdit::EchoMode mode = qobject_cast<QLineEdit *>(widget)->echoMode(); ...

12 years, 11 months ago (2013-03-01 17:10:22 UTC) #2

fujiwara

12 years, 11 months ago (2013-03-01 17:30:06 UTC) #3

https://codereview.appspot.com/7435050/diff/1/qtim/ibus-input-context.cpp
File qtim/ibus-input-context.cpp (right):

https://codereview.appspot.com/7435050/diff/1/qtim/ibus-input-context.cpp#new...
qtim/ibus-input-context.cpp:204: QLineEdit::EchoMode mode =
qobject_cast<QLineEdit *>(widget)->echoMode();
On 2013/03/01 17:10:22, Peng wrote:
> more than 80 chars

Done.

Expand All Messages | Collapse All Messages