Issue 7414045: Implement use-system-keyboard-layout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7414045: Implement use-system-keyboard-layout (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by fujiwara

Modified:
12 years, 11 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Implement use-system-keyboard-layout BUG=http://code.google.com/p/ibus/issues/detail?id=1558

Patch Set 2 : Updated with message #2. #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
	M	data/ibus.schemas.in	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/gtk3/panel.vala	View	1	6 chunks	+27 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm. with one comment https://codereview.appspot.com/7414045/diff/1/ui/gtk3/panel.vala File ui/gtk3/panel.vala (right): https://codereview.appspot.com/7414045/diff/1/ui/gtk3/panel.vala#newcode274 ui/gtk3/panel.vala:274: "use_system_keyboard_layout"); More than 80 chars

12 years, 11 months ago (2013-03-01 15:36:31 UTC) #2

fujiwara

12 years, 11 months ago (2013-03-01 17:29:43 UTC) #3

https://codereview.appspot.com/7414045/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/7414045/diff/1/ui/gtk3/panel.vala#newcode274
ui/gtk3/panel.vala:274: "use_system_keyboard_layout");
On 2013/03/01 15:36:32, Peng wrote:
> More than 80 chars

Done.

Expand All Messages | Collapse All Messages