Issue 7411046: Bench : Unused parameters cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7411046: Bench : Unused parameters cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by sugoi

Modified:
11 years, 9 months ago

Reviewers:
junov, junov1, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Bench : Unused parameters cleanup I removed unused parameters in bench wherever it was trivial to do so. Committed: https://code.google.com/p/skia/source/detail?r=7988

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -34 lines)			Patch
M	bench/AAClipBench.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	bench/BlurRectBench.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	bench/ChecksumBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/DashBench.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	bench/DecodeBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/GrMemoryPoolBench.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	bench/InterpBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/MathBench.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	bench/Matrix44Bench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/MatrixBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/MemoryBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/MutexBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/PathBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/PathIterBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/PictureRecordBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/RefCntBench.cpp	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	bench/RegionContainBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/SortBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/WriterBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

junov1

I agree that the identifiers add no useful information in all these places. lgtm

11 years, 9 months ago (2013-03-05 18:46:32 UTC) #2

sugoi

11 years, 9 months ago (2013-03-05 18:50:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r7988 (presubmit successful).

Expand All Messages | Collapse All Messages