src/pkg/runtime/mem_openbsd.c - Issue 7405045: code review 7405045: runtime: remove PROT_EXEC from mmap calls.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/mem_openbsd.c

Issue 7405045: code review 7405045: runtime: remove PROT_EXEC from mmap calls. (Closed)

Patch Set: diff -r d7ae1953ef1b https://code.google.com/p/go/ Created 12 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/mem_openbsd.c

===================================================================

--- a/src/pkg/runtime/mem_openbsd.c

+++ b/src/pkg/runtime/mem_openbsd.c

@@ -19,7 +19,7 @@

void *v;

mstats.sys += n;

- v = runtime·mmap(nil, n, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_ANON|MAP_PRIVATE, -1, 0);

+ v = runtime·mmap(nil, n, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE, -1, 0);

if(v < (void*)4096)

return nil;

return v;

@@ -65,7 +65,7 @@

// On 64-bit, we don't actually have v reserved, so tread carefully.

if(sizeof(void*) == 8) {

- p = runtime·mmap(v, n, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_ANON|MAP_PRIVATE, -1, 0);

+ p = runtime·mmap(v, n, PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE, -1, 0);

if(p == (void*)-ENOMEM)

runtime·throw("runtime: out of memory");

if(p != v) {

@@ -75,7 +75,7 @@

return;

}

- p = runtime·mmap(v, n, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_ANON|MAP_FIXED|MAP_PRIVATE, -1, 0);

+ p = runtime·mmap(v, n, PROT_READ|PROT_WRITE, MAP_ANON|MAP_FIXED|MAP_PRIVATE, -1, 0);

if(p == (void*)-ENOMEM)

runtime·throw("runtime: out of memory");

if(p != v)

« no previous file with comments | « src/pkg/runtime/mem_netbsd.c ('k') | no next file » | no next file with comments »