Fix make rpm errors due to ibus-dconf and pygobject override

Fix make rpm errors due to ibus-dconf and pygobject override


BUG=Issue#1600

Committed: e087814

[Peng, 2013-02-25 15:07:32]

https://codereview.appspot.com/7404047/diff/1/ibus.spec.in
File ibus.spec.in (right):

https://codereview.appspot.com/7404047/diff/1/ibus.spec.in#newcode8
ibus.spec.in:8: %define build_ibus_gconf 0
How about build both gconf and dconf? We could put them in ibus-gconf and
ibus-dconf sub packages

https://codereview.appspot.com/7404047/diff/1/ibus.spec.in#newcode214
ibus.spec.in:214: if [ $1 -eq 0 ] ; then
"$1" -eq "0"

[Daiki Ueno, 2013-02-26 03:41:36]

https://codereview.appspot.com/7404047/diff/1/ibus.spec.in
File ibus.spec.in (right):

https://codereview.appspot.com/7404047/diff/1/ibus.spec.in#newcode8
ibus.spec.in:8: %define build_ibus_gconf 0
On 2013/02/25 15:07:32, Peng wrote:
> How about build both gconf and dconf? We could put them in ibus-gconf and
> ibus-dconf sub packages

Good idea, done.  However, since rpm is not capable of handling OR condition of
requires, there is still %use_ibus_gconf flag.

https://codereview.appspot.com/7404047/diff/1/ibus.spec.in#newcode214
ibus.spec.in:214: if [ $1 -eq 0 ] ; then
On 2013/02/25 15:07:32, Peng wrote:
> "$1" -eq "0"

Done.

[Peng, 2013-02-26 04:41:27]

https://codereview.appspot.com/7404047/diff/1/ibus.spec.in
File ibus.spec.in (right):

https://codereview.appspot.com/7404047/diff/1/ibus.spec.in#newcode8
ibus.spec.in:8: %define build_ibus_gconf 0
On 2013/02/26 03:41:36, Daiki Ueno wrote:
> On 2013/02/25 15:07:32, Peng wrote:
> > How about build both gconf and dconf? We could put them in ibus-gconf and
> > ibus-dconf sub packages
> 
> Good idea, done.  However, since rpm is not capable of handling OR condition
of
> requires, there is still %use_ibus_gconf flag.
I remember rpm support %provide feature. Please try it.

For example:
%package ibus
%require: ibus-conf
...
%package dconf
%provide ibus-conf
...
%package dconf
%provide ibus-conf
...

[Daiki Ueno, 2013-02-26 09:39:53]

On 2013/02/26 04:41:27, Peng wrote:
> I remember rpm support %provide feature. Please try it.
> 
> For example:
> %package ibus
> %require: ibus-conf
> ...
> %package dconf
> %provide ibus-conf
> ...
> %package dconf
> %provide ibus-conf
> ...

Yes, it seems to work, thanks.
Updated CL.

[Peng, 2013-02-26 18:50:04]

lgtm. Thanks.