Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(693)

Issue 7400053: Consolidate functions common the the null and debug GL interfaces. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by bsalomon
Modified:
11 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Consolidate functions common the the null and debug GL interfaces. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=7860

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1106 lines, -994 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLBogusInterface.h View 1 1 chunk +355 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLBogusInterface.cpp View 1 1 chunk +565 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 2 6 chunks +94 lines, -328 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 13 chunks +90 lines, -666 lines 0 comments Download

Messages

Total messages: 3
bsalomon
I'm going to have to update these to add core profile support so I figured ...
11 years, 9 months ago (2013-02-25 19:17:32 UTC) #1
robertphillips
lgtm but I think we need a more different name than 'bogus' maybe utility, util, ...
11 years, 9 months ago (2013-02-26 14:21:54 UTC) #2
bsalomon
11 years, 9 months ago (2013-02-26 14:35:33 UTC) #3
Message was sent while issue was closed.
On 2013/02/26 14:21:54, robertphillips wrote:
> lgtm but I think we need a more different name than 'bogus' maybe utility,
util,
> helper, empty.

Renamed to "noOp"
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b