Issue 7400049: Make GPU versions of benchs use the same canvas size as raster.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7400049: Make GPU versions of benchs use the same canvas size as raster. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by bsalomon

Modified:
11 years, 6 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make GPU versions of benchs use the same canvas size as raster. Committed: https://code.google.com/p/skia/source/detail?r=7827

Patch Set 2 : #

Total comments: 4

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -155 lines)			Patch
	M	bench/benchmain.cpp	View	1	13 chunks	+83 lines, -154 lines	4 comments	Download
	M	include/gpu/GrContextFactory.h	View		2 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

lgtm https://codereview.appspot.com/7400049/diff/2001/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.appspot.com/7400049/diff/2001/bench/benchmain.cpp#newcode621 bench/benchmain.cpp:621: Why not pass in SK_ARRAY_COUNT(gConfigs) here? https://codereview.appspot.com/7400049/diff/2001/bench/benchmain.cpp#newcode685 bench/benchmain.cpp:685: ...

11 years, 6 months ago (2013-02-22 16:09:24 UTC) #2

bsalomon

11 years, 6 months ago (2013-02-22 16:13:32 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/7400049/diff/2001/bench/benchmain.cpp
File bench/benchmain.cpp (right):

https://codereview.appspot.com/7400049/diff/2001/bench/benchmain.cpp#newcode621
bench/benchmain.cpp:621: 
On 2013/02/22 16:09:24, robertphillips wrote:
> Why not pass in SK_ARRAY_COUNT(gConfigs) here?

Done.

https://codereview.appspot.com/7400049/diff/2001/bench/benchmain.cpp#newcode685
bench/benchmain.cpp:685: context =
gContextFactory.get(gConfigs[configIndex].fContextType);
On 2013/02/22 16:09:24, robertphillips wrote:
> NULL ==?

Done.

Expand All Messages | Collapse All Messages