Issue 7397043: Make ANGLE bot run only ANGLE configs in bench_pictures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7397043: Make ANGLE bot run only ANGLE configs in bench_pictures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by EricB

Modified:
11 years, 9 months ago

Reviewers:
Leon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make ANGLE bot run only ANGLE configs in bench_pictures Committed: https://code.google.com/p/skia/source/detail?r=7799

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/bench_pictures.cfg	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	tools/bench_pictures_cfg_helper.py	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

EricB

On 2013/02/20 19:52:50, Leon wrote: > On 2013/02/20 19:51:53, EricB wrote: > > lgtm Uploaded ...

11 years, 9 months ago (2013-02-20 19:59:02 UTC) #3

Leon

11 years, 9 months ago (2013-02-20 20:00:20 UTC) #4

On 2013/02/20 19:59:02, EricB wrote:
> On 2013/02/20 19:52:50, Leon wrote:
> > On 2013/02/20 19:51:53, EricB wrote:
> > 
> > lgtm
> 
> Uploaded patch set 2.  Patch set 1 failed because TiledBitmapConfig forces
> device='bitmap'.  Whoops.

lgtm

Expand All Messages | Collapse All Messages