Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(817)

Issue 7395055: Give GrDrawTarget a back ptr to its owning GrContext. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by bsalomon
Modified:
11 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Give GrDrawTarget a back ptr to its owning GrContext. Committed: https://code.google.com/p/skia/source/detail?r=7850

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -164 lines) Patch
M include/gpu/GrContext.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 6 chunks +56 lines, -60 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +6 lines, -12 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpuFactory.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 4 chunks +6 lines, -19 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 7 chunks +50 lines, -55 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
bsalomon
I'm going to want to make GrDrawTarget use the cache to get a texture when ...
11 years, 9 months ago (2013-02-25 14:00:33 UTC) #1
robertphillips
lgtm except for the succeeded bit which I can live with but I'm hoping there ...
11 years, 9 months ago (2013-02-25 14:12:52 UTC) #2
bsalomon
Good suggestion. I added an init() to GrContext in the updated patch. https://codereview.appspot.com/7395055/diff/1/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h ...
11 years, 9 months ago (2013-02-25 14:53:31 UTC) #3
robertphillips
11 years, 9 months ago (2013-02-25 16:36:06 UTC) #4
lgtm - I like that better
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b