Issue 7394055: Tests : Unused parameters cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7394055: Tests : Unused parameters cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by sugoi

Modified:
11 years, 7 months ago

Reviewers:
junov, bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Tests : Unused parameters cleanup I removed unused parameters in the tests wherever it was trivial to do so. I'm trying to get the easy ones out of the way before we get into more involved discussions around this. Committed: https://code.google.com/p/skia/source/detail?r=7891

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -78 lines)			Patch
M	tests/AAClipTest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/BlitRowTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/CanvasTest.cpp	View	6 chunks	+12 lines, -12 lines	0 comments	Download
M	tests/ClipperTest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/ColorTest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/DeferredCanvasTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/DrawBitmapRectTest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/DrawPathTest.cpp	View	9 chunks	+16 lines, -16 lines	0 comments	Download
M	tests/EmptyPathTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/MemsetTest.cpp	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/PathCoverageTest.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/PathMeasureTest.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/PathTest.cpp	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	tests/PictureTest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/ReadPixelsTest.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/TLSTest.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/TileGridTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/WritePixelsTest.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/skia_test.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2013/02/27 15:24:01, sugoi wrote:

lgtm

Expand All Messages | Collapse All Messages