Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 7392049: code review 7392049: Add 'go-mode-show-gofmt-errors' to control displa...

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by markcol
Modified:
11 years ago
Reviewers:
CC:
Sameer Ajmani, sameer_golango.org, gobot, adonovan, golang-codereviews
Visibility:
Public.

Description

Add 'go-mode-show-gofmt-errors' to control display of gofmt errors. Set the variable to nil to completely ignore gofmt errors, or non-nil to display the errors in a buffer. The value default to 't. Documentation about the variable can be displayed within Emacs using 'M-x describe-variable'. Some people like the ability to temporarily disable gofmt errors when saving a file while using gofmt to autmoatically format code using the before-save-hook. To do this, use the following: (defun my-gofmt-before-save-hook () (let ((go-mode-show-gofmt-errors nil)) (when (eq major-mode 'go-mode) (gofmt)))) (add-hook 'before-save-hook #'my-gofmt-before-save-hook)

Patch Set 1 #

Patch Set 2 : diff -r bfb45be43e2b https://code.google.com/p/go #

Patch Set 3 : diff -r 8e4103edc064 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M misc/emacs/go-mode.el View 1 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 4
markcol
Hello sameer@golang.org, sameer@golango.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 10 months ago (2013-02-25 23:28:57 UTC) #1
gobot
R=adonovan@google.com (assigned by sameer@golang.org)
12 years ago (2013-12-20 15:42:14 UTC) #2
gobot
Replacing golang-dev with golang-codereviews.
12 years ago (2013-12-20 16:21:42 UTC) #3
gobot
11 years ago (2014-12-19 05:18:24 UTC) #4
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/7392049 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b