Issue 7388061: Removing blank lines from codereview.settings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7388061: Removing blank lines from codereview.settings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rmistry

Modified:
11 years, 9 months ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com, skiabot_google.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

Removing blank lines from codereview.settings. depot_tools/checkout.py does not like blank lines: https://github.com/beurdouche/tools/blob/master/depot_tools/checkout.py#L38 Due to blank lines in our codereview.settings it was not returning the correct VIEW_VC and due to this the 'Commited' line was not showing up in changes submitted by the commit-queue. (SkipBuildbotRuns) Committed: https://code.google.com/p/skia/source/detail?r=7865

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	codereview.settings	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	trunk/codereview.settings	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmistry

11 years, 9 months ago (2013-02-26 16:01:02 UTC) #3

On 2013/02/26 15:57:48, EricB wrote:
> LGTM, but will the housekeeper add these newlines back?

No, it only sanitizes files that end in ['cpp', 'h', 'c', 'gyp', 'gypi'].

Expand All Messages | Collapse All Messages