Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(210)

Issue 7388061: Removing blank lines from codereview.settings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by rmistry
Modified:
11 years, 8 months ago
Reviewers:
EricB
CC:
skia-review_googlegroups.com, skiabot_google.com
Base URL:
http://skia.googlecode.com/svn/
Visibility:
Public.

Description

Removing blank lines from codereview.settings. depot_tools/checkout.py does not like blank lines: https://github.com/beurdouche/tools/blob/master/depot_tools/checkout.py#L38 Due to blank lines in our codereview.settings it was not returning the correct VIEW_VC and due to this the 'Commited' line was not showing up in changes submitted by the commit-queue. (SkipBuildbotRuns) Committed: https://code.google.com/p/skia/source/detail?r=7865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M codereview.settings View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/codereview.settings View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
rmistry
11 years, 8 months ago (2013-02-26 15:56:39 UTC) #1
EricB
LGTM, but will the housekeeper add these newlines back?
11 years, 8 months ago (2013-02-26 15:57:48 UTC) #2
rmistry
11 years, 8 months ago (2013-02-26 16:01:02 UTC) #3
On 2013/02/26 15:57:48, EricB wrote:
> LGTM, but will the housekeeper add these newlines back?

No, it only sanitizes files that end in ['cpp', 'h', 'c', 'gyp', 'gypi'].
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b