Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(628)

Issue 7388050: Remove bogus ability for creating an SkPicturePlayback to fail. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Leon
Modified:
11 years, 8 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Remove bogus ability for creating an SkPicturePlayback to fail. Change SkPicturePlayback::parseBufferTag to return void, since it can never return false. Change SkPicturePlayback::parseStreamTag to return void, since the only way it can return false is if parseBufferTag returns false, or if creating a sub picture failed, both of which are nonsensical. Due to the above, there is no reason for creating an SkPicturePlayback to fail, so remove the isValid parameter. Update subclasses in SkDebuggerGUI. Committed: https://code.google.com/p/skia/source/detail?r=7844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -57 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 4 chunks +6 lines, -18 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M src/core/SkPicturePlayback.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 5 chunks +13 lines, -29 lines 0 comments Download

Messages

Total messages: 3
Leon
11 years, 8 months ago (2013-02-22 22:56:49 UTC) #1
reed1
lgtm
11 years, 8 months ago (2013-02-25 13:41:25 UTC) #2
robertphillips
11 years, 8 months ago (2013-02-25 13:57:37 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b