Issue 7386055: Fixed sk_getMetrics_utf32_xy function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7386055: Fixed sk_getMetrics_utf32_xy function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by sugoi

Modified:
11 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixed sk_getMetrics_utf32_xy function The unused parameters x and y here seems to be a mistake. Committed: https://code.google.com/p/skia/source/detail?r=7873

Patch Set 1 #

Total comments: 3

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/core/SkPaint.cpp	View		2 chunks	+2 lines, -2 lines	3 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

sugoi

I think these unused parameters were a mistake. You tell me. https://codereview.appspot.com/7386055/diff/1/src/core/SkPaint.cpp File src/core/SkPaint.cpp (right): ...

11 years, 8 months ago (2013-02-26 20:34:51 UTC) #1

reed1

11 years, 8 months ago (2013-02-26 21:54:08 UTC) #2

lgtm

https://codereview.appspot.com/7386055/diff/1/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

https://codereview.appspot.com/7386055/diff/1/src/core/SkPaint.cpp#newcode845
src/core/SkPaint.cpp:845: return cache->getUnicharMetrics(uni, x, y);
good catch

https://codereview.appspot.com/7386055/diff/1/src/core/SkPaint.cpp#newcode1692
src/core/SkPaint.cpp:1692: void SkScalerContext::PostMakeRec(const SkPaint&,
SkScalerContext::Rec* rec) {
agreed, renaming a class type with the same word usually adds no value.

Expand All Messages | Collapse All Messages