Document Kievan ligature engraver

Document Kievan ligature engraver

Adds subsection about Kievan ligatures to ancient notation section of notation manual.

[aleksandr.andreev, 2013-02-25 19:51:42]

Please review.

[Trevor Daniels, 2013-02-26 16:07:33]

One suggested change; otherwise LGTM.

Trevor

https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient....
File Documentation/notation/ancient.itely (right):

https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient....
Documentation/notation/ancient.itely:2607: \new KievanVoice = "melody"
\transpose c c' {
I'd rather this be \relative c' rather than \transpose c c'
to be in keeping with the style in the rest of the manual.

[aleksandr.andreev, 2013-02-27 03:26:11]

On 2013/02/26 16:07:33, Trevor Daniels wrote:
> One suggested change; otherwise LGTM.
> 
> Trevor
> 
>
https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient....
> File Documentation/notation/ancient.itely (right):
> 
>
https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient....
> Documentation/notation/ancient.itely:2607: \new KievanVoice = "melody"
> \transpose c c' {
> I'd rather this be \relative c' rather than \transpose c c'
> to be in keeping with the style in the rest of the manual.

Looking at the sections on Mensural and Gregorian notations, it looks like the
\transpose c c' syntax is used quite often there. On the other hand, the
\relative syntax is used in the "scenarios and solutions" section. I don't mind
changing this example (as well as the example at the beginning of the Kievan
section), but perhaps we should then make all of the examples in the Ancient
notation chapter consistent?

[Trevor Daniels, 2013-02-27 09:24:07]

On 2013/02/27 03:26:11, aleksandr.andreev wrote:
> Looking at the sections on Mensural and Gregorian notations, it looks like the
> \transpose c c' syntax is used quite often there. On the other hand, the
> \relative syntax is used in the "scenarios and solutions" section. I don't
mind
> changing this example (as well as the example at the beginning of the Kievan
> section), but perhaps we should then make all of the examples in the Ancient
> notation chapter consistent?

I think changing all the examples to \relative would be good, but I'm happy to
leave this to a separate patch if you prefer.  The Ancient section was not
included in the push for consistency some years ago due to lack of
interest/effort.  But better late than never.

Trevor

[aleksandr.andreev, 2013-02-27 14:49:54]

On 2013/02/27 09:24:07, Trevor Daniels wrote:
> On 2013/02/27 03:26:11, aleksandr.andreev wrote:
> > Looking at the sections on Mensural and Gregorian notations, it looks like
the
> > \transpose c c' syntax is used quite often there. On the other hand, the
> > \relative syntax is used in the "scenarios and solutions" section. I don't
> mind
> > changing this example (as well as the example at the beginning of the Kievan
> > section), but perhaps we should then make all of the examples in the Ancient
> > notation chapter consistent?
> 
> I think changing all the examples to \relative would be good, but I'm happy to
> leave this to a separate patch if you prefer.  The Ancient section was not
> included in the push for consistency some years ago due to lack of
> interest/effort.  But better late than never.
> 
> Trevor

I think it makes sense to push this patch first and then I will upload another
patch that changes the syntax across the manual. That way it is cleaner in the
commit history.

There is also Issue 1287. I could try to work on improving the ancient notation
chapter, though I am no expert in Gregorian chant.

[t.daniels_treda.co.uk, 2013-02-28 09:05:09]

aleksandr.andreev wrote Wednesday, February 27, 2013 2:49 PM

> I think it makes sense to push this patch first and then I will upload
> another patch that changes the syntax across the manual. That way it is
> cleaner in the commit history.

Fine by me.
 
> There is also Issue 1287. I could try to work on improving the ancient
> notation chapter, though I am no expert in Gregorian chant.

That would be very welcome indeed!

Trevor

[Graham Percival, 2013-02-28 23:49:36]

LGTM