Pointing CODE_REVIEW_SERVER to Chromium Rietveld

Pointing CODE_REVIEW_SERVER to Chromium Rietveld.

(SkipBuildbotRuns)
Committed: https://code.google.com/p/skia/source/detail?r=7858

[rmistry, 2013-02-25 14:29:49]

https://codereview.appspot.com/7382058/diff/5001/trunk/codereview.settings
File trunk/codereview.settings (right):

https://codereview.appspot.com/7382058/diff/5001/trunk/codereview.settings#ne...
trunk/codereview.settings:1: # This file is used by gcl to get repository
specific information.
Adding this file because of a bug/misfeature with the commit queue.

Without this file in trunk/ the commit-queue does not know what the VIEW_VC is
and thus did not add a 'Committed' line in the description of
https://codereview.chromium.org/12320040 like it did for
https://codereview.chromium.org/12335031

I mentioned this to Marc-Antoine, the easiest solution for us to get this
feature is to add a duplicate codereview.settings to trunk. When/if this is
fixed in the future we can remove this file.

[EricB, 2013-02-25 15:32:51]

LGTM.  Make sure you send a PSA describing how to clear the cache so that this
takes effect.

https://codereview.appspot.com/7382058/diff/5001/trunk/codereview.settings
File trunk/codereview.settings (right):

https://codereview.appspot.com/7382058/diff/5001/trunk/codereview.settings#ne...
trunk/codereview.settings:1: # This file is used by gcl to get repository
specific information.
On 2013/02/25 14:29:49, rmistry wrote:
> Adding this file because of a bug/misfeature with the commit queue.
> 
> Without this file in trunk/ the commit-queue does not know what the VIEW_VC is
> and thus did not add a 'Committed' line in the description of
> https://codereview.chromium.org/12320040 like it did for
> https://codereview.chromium.org/12335031
> 
> I mentioned this to Marc-Antoine, the easiest solution for us to get this
> feature is to add a duplicate codereview.settings to trunk. When/if this is
> fixed in the future we can remove this file.

This will likely also fix the annoying (but harmless) warning when submitting a
try request: "No codereview.settings file found"

[rmistry, 2013-02-25 15:34:20]

On 2013/02/25 15:32:51, EricB wrote:
> LGTM.  Make sure you send a PSA describing how to clear the cache so that this
> takes effect.

Yes, I'll update the email I sent out in the morning after this is submitted
(hopefully tomorrow).

> 
> https://codereview.appspot.com/7382058/diff/5001/trunk/codereview.settings
> File trunk/codereview.settings (right):
> 
>
https://codereview.appspot.com/7382058/diff/5001/trunk/codereview.settings#ne...
> trunk/codereview.settings:1: # This file is used by gcl to get repository
> specific information.
> On 2013/02/25 14:29:49, rmistry wrote:
> > Adding this file because of a bug/misfeature with the commit queue.
> > 
> > Without this file in trunk/ the commit-queue does not know what the VIEW_VC
is
> > and thus did not add a 'Committed' line in the description of
> > https://codereview.chromium.org/12320040 like it did for
> > https://codereview.chromium.org/12335031
> > 
> > I mentioned this to Marc-Antoine, the easiest solution for us to get this
> > feature is to add a duplicate codereview.settings to trunk. When/if this is
> > fixed in the future we can remove this file.
> 
> This will likely also fix the annoying (but harmless) warning when submitting
a
> try request: "No codereview.settings file found"

Yes it should.

[epoger, 2013-02-26 16:20:44]

LGTM!