Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(590)

Issue 7381061: When CheckDeviceStats returns S_PRESENT_MODE_CHANGED, reset display mode and retest for device lost. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by apatrick1
Modified:
11 years, 1 month ago
Reviewers:
shannon.woods, federalcarlin, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When CheckDeviceStats returns S_PRESENT_MODE_CHANGED, reset display mode and retest for device lost. Unless the display mode is reset, CheckDeviceLost can keep returning S_PRESENT_MODE_CHANGED, potentially masking a device lost on account of a GPU hang, causing ANGLE to fail to report context lost. Committed: https://code.google.com/p/angleproject/source/detail?r=1986

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M src/libEGL/Display.cpp View 1 1 chunk +19 lines, -3 lines 0 comments Download

Messages

Total messages: 6
apatrick1
This seems to be a better way to deal with S_PRESENT_MODE_CHANGED. It doesn't treat every ...
11 years, 1 month ago (2013-02-27 22:07:57 UTC) #1
federalcarlin
reset display mode and retest for device lost.
11 years, 1 month ago (2013-02-27 23:18:36 UTC) #2
apatrick1
Hi. I'm running out of time to land this in time for M26. Is it ...
11 years, 1 month ago (2013-03-04 20:31:33 UTC) #3
nicolas
I don't think testDeviceResettable() should do the Reset. That could cause glGetGraphicsResetStatusEXT() to never return ...
11 years, 1 month ago (2013-03-04 20:40:06 UTC) #4
apatrick1
Good point. It still works without the change to testDeviceResettable.
11 years, 1 month ago (2013-03-04 20:50:39 UTC) #5
nicolas
11 years, 1 month ago (2013-03-04 20:53:18 UTC) #6
Looks ok to me now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b